Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip on focus + hover #328

Merged
merged 4 commits into from
Mar 1, 2021
Merged

Conversation

ahmadayubi
Copy link
Member

@ahmadayubi ahmadayubi commented Mar 1, 2021

2021-03-01.11-26-56.mp4

The first square is created using:

<feature zoom="2" class="refDiff">
  <featurecaption>Accessible Square</featurecaption>
  <properties>
    <h1>Test</h1>
    <a href="www.example.com">test</a>
  </properties>
  <geometry cs="tilematrix">
    <polygon>
      <coordinates>11 11 12 11 12 12 11 12</coordinates>
    </polygon>
  </geometry>
</feature>

Closes #327

@ahmadayubi ahmadayubi marked this pull request as ready for review March 1, 2021 16:41
@prushforth
Copy link
Member

I believe the <title> only is presented if it is found in inline layer DOM, not found in <layer- src=...> layers. Let's wait until we've figured out what this element will be called during upcoming meeting hopefully.

@prushforth
Copy link
Member

OK, so per the discussion at today's meeting with @shepazu , we'll go with <featurecaption> for now.

@prushforth prushforth merged commit 3fabcf9 into Maps4HTML:master Mar 1, 2021
@prushforth
Copy link
Member

Darn I just noticed that when you use the ">" or "<" affordances you don't get the tooltip when focus goes to the next/previous feature. Sorry I should have checked more thoroughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "tooltip" display on focus / hover event
2 participants