Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <featurecaption> element child of <feature> #163

Merged
merged 9 commits into from
Mar 2, 2021
Merged

Add <featurecaption> element child of <feature> #163

merged 9 commits into from
Mar 2, 2021

Conversation

prushforth
Copy link
Member

@prushforth prushforth commented Mar 1, 2021 •
edited
Loading

per Maps4HTML/MapML.js#316.

Change mapml vocabulary to the xhtml namespace.

Fix error in URL introduced in previous commit.

@prushforth prushforth requested a review from Malvoz March 1, 2021 21:25
Malvoz
Malvoz reviewed Mar 1, 2021
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
Malvoz
Malvoz requested changes Mar 2, 2021
View reviewed changes
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

featurecaption needs to be added to the content model of the feature element as an optional element.

@prushforth
Copy link
Member Author

Good call, I'll make those changes. Thanks!

@Malvoz
Copy link
Member

Malvoz commented Mar 2, 2021 •
edited
Loading

Also this PR has merge conflicts it seems, although I can't make out what those are. 🤷🏼‍♂️

@prushforth prushforth changed the title Add text-valued <title> element child of <feature> per https://github… Add text-valued <featurecaption> element child of <feature> per https://github… Mar 2, 2021
@prushforth prushforth changed the title Add text-valued <featurecaption> element child of <feature> per https://github… Add <featurecaption> element child of <feature> per https://github… Mar 2, 2021
@prushforth prushforth requested a review from Malvoz March 2, 2021 15:22
@prushforth prushforth changed the title Add <featurecaption> element child of <feature> per https://github… Add <featurecaption> element child of <feature> Mar 2, 2021
Malvoz
Malvoz reviewed Mar 2, 2021
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
Malvoz
Malvoz reviewed Mar 2, 2021
View reviewed changes
spec/index.html Outdated Show resolved Hide resolved
Malvoz
Malvoz approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many elements need more detailed descriptions, future work though. LGTM.

@prushforth prushforth merged commit 1eff5e0 into Maps4HTML:gh-pages Mar 2, 2021
@prushforth prushforth mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malvoz Malvoz Malvoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prushforth @Malvoz