Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Manual Core format to allow separation from data files #122

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qwint
Copy link

@qwint qwint commented Dec 22, 2024

adds framework to split out manual core files from the shipped manual game data format, and includes a simple way to import a ".manuworld" (theoretically can just be a .zip if that makes more sense) without hooks for a safer import

TODOs:

  • flesh out the codepath where you do want to import hooks
  • Options.make_options_group is completely broken and its uses commented out
  • make helpers load methods work as expected and/or refactor them altogether
  • figure out if one of the changes is why manual client hangs on launch and fix it
  • more thorough debugging to make sure no other things need refactors

I'm not sure I'll finish this to completion, so if anyone wants to take inspiration (or the entire branch wholesale) feel free to do so
but can obviously make/approve minor changes for style/design

… game data format, and includes a simple way to import a ".manuworld" without hooks for a safer import

TODOs:
* flesh out the codepath where you do want to import hooks
* Options.make_options_group is completely broken and its uses commented out
@FuzzyGamesOn
Copy link
Collaborator

FuzzyGamesOn commented Dec 23, 2024

Thanks for submitting this PoC, qwint. 😃

From the description, it sounds like this is an unfinished PR, so please switch it to a draft PR in the meantime. We review drafts as well, but marking it as a draft indicates that it's not expected to be ready to merge once reviews are complete.

@qwint qwint marked this pull request as draft December 23, 2024 16:33
@qwint
Copy link
Author

qwint commented Dec 23, 2024

yea, it's fully functional in the one codepath of load all the ".manuworld" files as json-only from the user's custom_worlds (or userdata worlds on machines that use that instead), but like the TODOs mention it does break some existing functionality so it probably shouldn't be merged as-is yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants