Skip to content

Commit

Permalink
realized from the upgrade steps that Manual's filler placement at the…
Browse files Browse the repository at this point in the history
… end of the pool wasn't using the get_filler_item_name method
  • Loading branch information
FuzzyGamesOn committed Sep 27, 2024
1 parent 958874e commit 0dc9d06
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ def create_items(self):
configured_item_names = self.item_id_to_name.copy()

for name in configured_item_names.values():
# victory gets placed via place_locked_item at the victory location in create_regions
if name == "__Victory__": continue
# the game.json filler item name is added to the item lookup, so skip it until it's potentially needed later
if name == filler_item_name: continue

item = self.item_name_to_item[name]
Expand Down Expand Up @@ -355,8 +357,10 @@ def adjust_filler_items(self, item_pool, traps):
extra_item = self.create_item(self.random.choice(traps))
item_pool.append(extra_item)

filler_name_to_add = self.get_filler_item_name()

for _ in range(0, filler_count):
extra_item = self.create_item(filler_item_name)
extra_item = self.create_item(filler_name_to_add)
item_pool.append(extra_item)
elif extras < 0:
logging.warning(f"{self.game} has more items than locations. {abs(extras)} non-progression items will be removed at random.")
Expand Down

0 comments on commit 0dc9d06

Please sign in to comment.