Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Experimental] Start Migration Guide #4060

Merged
merged 4 commits into from
Dec 16, 2024
Merged

[Experimental] Start Migration Guide #4060

merged 4 commits into from
Dec 16, 2024
+98 −0

Conversation

JasonGrace2282
Copy link
Member

Starts a basic migration guide, so we can keep track of major changes in experimental

@JasonGrace2282 JasonGrace2282 added documentation Improvements or additions to documentation experimental labels Dec 16, 2024
chopan050
chopan050 requested changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! I left some comments.

By the way, why {class}, {meth} and {attr} instead of :class:, :meth: and :attr:?

docs/source/changelog/experimental.md Outdated Show resolved Hide resolved
docs/source/changelog/experimental.md Outdated Show resolved Hide resolved
docs/source/changelog/experimental.md Outdated Show resolved Hide resolved
docs/source/changelog/experimental.md Show resolved Hide resolved
docs/source/changelog/experimental.md Outdated Show resolved Hide resolved
@JasonGrace2282
Copy link
Member Author

It's looking good! I left some comments.

By the way, why {class}, {meth} and {attr} instead of :class:, :meth: and :attr:?

It's how you cross reference with myst-markdown.

@JasonGrace2282 @chopan050
Fix typo pt2
43f2c77 
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
@JasonGrace2282 JasonGrace2282 merged commit 3911643 into ManimCommunity:experimental Dec 16, 2024
2 of 4 checks passed
@JasonGrace2282 JasonGrace2282 deleted the migration-guide-exp branch December 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopan050 chopan050 chopan050 requested changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGrace2282 @chopan050