Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triangle CN prove version #4046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Crisforlove
Copy link

Overview: What does this pull request change?

Added a Chinese version of a demo that proves the sum of the interior angles of a triangle. Two methods are demonstrated to prove this fundamental geometry concept.

Motivation and Explanation: Why and how do your changes improve the library?

This PR introduces a Chinese-language demo proving the sum of the interior angles of a triangle. It offers two methods for users to explore, enriching the educational content of the library and providing a more accessible version for Chinese-speaking users.

Links to added or changed documentation pages

Further Information and Comments

The demonstration showcases two distinct methods to prove that the sum of the interior angles of a triangle equals 180 degrees. This adds value to the educational materials in the Manim community, particularly for those who prefer or need content in Chinese.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Crisforlove and others added 2 commits December 6, 2024 16:45
This is a Chinese version of a demo that proves the sum of the interior angles of a triangle. Two methods are tried to prove
@JasonGrace2282
Copy link
Member

Hey, thanks for your interesting in contributing to Manim!
We appreciate your enthusiasm for adding documentation (it is something that can always be improved!), and especially for adding it in a non-english language.
However, I'm not sure if a separate example in Chinese is the right way to go with this. Manim has a system for adding translations in other languages, so maybe some documentation examples in English, followed by an i18n translation into Chinese is a better way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants