-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename InternalPoint3D
to Point3D
, Point3D
to Point3DLike
and other point-related type aliases
#4027
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't taken an in-depth look at the changes, but could you also update our docs on choosing typehints?
https://manimce--4027.org.readthedocs.build/en/4027/contributing/docs/types.html
Done! Please, take a look and tell me what you think about it, @JasonGrace2282 |
To me, this indicates that we also need Also, it's a bit weird that I would like to discuss this more. If we agree on this, I could add those |
"""Wrap ``function``'s output inside a NumPy array.""" | ||
return np.asarray(function(t)) | ||
|
||
self.function = internal_parametric_function |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning
FunctionGraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this PR!
Definitely looking forward to this change. Left a few comments, would appreciate if you could take a look when you find time.
Closes #4016
Reviewer Checklist