update: Refactoring Code-class and new Custom pygments based formatter #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
added 4 commits
August 16, 2024 10:55
* Refactoring whole Code class from old Html- parser to use new custom Formatter * Cutting Code-class internal attributes on which information comes from user * Moved Object Constructor methods to separate functions Depricated: * Generate_html_file argument won't fit with current formatter. * Indentation_chars argument, is no more needed Feature: * Custom Formatter based on Pygments backend. * Utility_file to Code-class testing * Added tests * Runtime error handling tested: * pygments 2.18.0
* Little linter-error fixes
* Little linter-error fixes * More error fixes
so it can handle more hidden Tokenizer quirks automatically * Removing newlines from end -> Those causes Paragraph class to missbehave and enproduct had code line-number miss alignment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
CodeclassCodeColorFormatterMotivation and Explanation: Why and how do your changes improve the library?
pygmentsHtmlFormatter as backend and after parsed html tolist[tuple[str,str]]structure which is used for coloring.pygmentslexers and tokenizer functions.Links to added or changed documentation pages
Further Information and Comments
** There may be some odd cases when pygments Tokenizer sneak newlines to unexpected places. Testes with different syntax and languages would be good to perform.
** If uncatched newlines is passed to
Paragraphinside of string literals it will broke re-coloring an line-numbers.Reviewer Checklist