Experimental update #3357

jsonvillanueva · 2023-09-04T02:40:50Z

Overview: What does this pull request change?

This PR brings the experimental changes up-to-date with v0.17.3 and attempts to separate the Renderer specific logic from Scene and Mobject.

Of particular interest is the Renderer ABC and the RendererData classes.

This PR is still a work in progress.

TODO:

Remove OpenGLMobject/OpenGLVMobject
Render a black screen
Render a drawable with OpenGL/Cairo
Interactivity
???

…#3126) * docs: change links redirecting to dead troubleshooting page * Fix typo in FAQ link Co-authored-by: elyanah <[email protected]>

…imCommunity#3105) * Convert docstring param type to type-hint in three_dimensions.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: Tristan Schulz <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Tristan Schulz <[email protected]>

updates: - [github.com/pre-commit/pygrep-hooks: v1.9.0 → v1.10.0](pre-commit/pygrep-hooks@v1.9.0...v1.10.0) - [github.com/asottile/blacken-docs: v1.12.1 → 1.13.0](adamchainz/blacken-docs@v1.12.1...1.13.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

) * Add scene.replace() and use in ReplacementTransform This replace method allows one mobject to take the place (that is, the draw order) of another mobject. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Address Feedback * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update visual Replacement test and fix extract_frames.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * allow flake8 to be unhappy Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Benjamin Hackl <[email protected]>

Wether -> Whether

* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pycqa/isort: 5.11.4 → 5.12.0](PyCQA/isort@5.11.4...5.12.0) - [github.com/psf/black: 22.12.0 → 23.1.0](psf/black@22.12.0...23.1.0) * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

see ManimCommunity#3130

…ity#3152) * fixed behavior of stop_condition in Wait * updated documentation to reflect actual behavior of wait_until etc * added test for Wait with stop_condition and Scene.wait_until * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Bumps [markdown-it-py](https://github.com/executablebooks/markdown-it-py) from 2.1.0 to 2.2.0. - [Release notes](https://github.com/executablebooks/markdown-it-py/releases) - [Changelog](https://github.com/executablebooks/markdown-it-py/blob/master/CHANGELOG.md) - [Commits](executablebooks/markdown-it-py@v2.1.0...v2.2.0) --- updated-dependencies: - dependency-name: markdown-it-py dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ipython](https://github.com/ipython/ipython) from 8.7.0 to 8.10.0. - [Release notes](https://github.com/ipython/ipython/releases) - [Commits](ipython/ipython@8.7.0...8.10.0) --- updated-dependencies: - dependency-name: ipython dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* typo(docs): Fix grammar * fix typo in source code

Without this unpacking values returned from get_value_trackers could have one too many.

…nity#3149) * Allow to use call_updater=True with a function without dt * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: Benjamin Hackl <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

updates: - [github.com/pre-commit/mirrors-mypy: v0.991 → v1.0.1](pre-commit/mirrors-mypy@v0.991...v1.0.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Benjamin Hackl <[email protected]>

* fix: BraceLabel not passing **kwargs to Brace * create an empty dict if brace_config is None * added typehints and included comments made * added missing type hints in BraceLabel.__init__ * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fixed docstring indentation * remove superfluous import --------- Co-authored-by: Benjamin Hackl <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…ommunity#3186)

* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/mirrors-mypy: v1.0.1 → v1.1.1](pre-commit/mirrors-mypy@v1.0.1...v1.1.1) - [github.com/codespell-project/codespell: v2.2.2 → v2.2.4](codespell-project/codespell@v2.2.2...v2.2.4) * ignore poetry.lock when running codespell * explicitly only spellcheck py/md/rst files * try again, different syntax --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Benjamin Hackl <[email protected]>

`win32` -> `windows` due to 64-bit binaries

) Limit condition to interactive OpenGL mode Co-authored-by: Benjamin Hackl <[email protected]>

…animCommunity#3189) * Update space_ops.py * Apply suggestions from code review --------- Co-authored-by: Benjamin Hackl <[email protected]>

* Reduce memory allocations when building SVGMobject * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * split two quads * fix shape * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * assign * Fix lines * Add some tests and fix extra lineto * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Appease assertion CQ check --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* Speed up width/height/depth by reducing copying * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix test * fix example and improve tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * imports * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * typo * np.max/min is 2x slower than max/min --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…und_corners` (ManimCommunity#3155) * feat(Polygram.round_corners): add support for individualized radius values * Update manim/mobject/geometry/polygram.py Remove type hints from the docstring of round_corners() Co-authored-by: Benjamin Hackl <[email protected]> * Update rounded_corners() so that integer values are accepted --------- Co-authored-by: Benjamin Hackl <[email protected]>

Co-authored-by: Benjamin Hackl <[email protected]>

…arts of Tex mobjects (ManimCommunity#3159) * Added MathTex.set_opacity_by_tex and MathTex.fade_all_but_tex * Completed unittests for set_opacity_by_tex and fade_all_but_tex * Added control_data for `fade_all_but_tex` and `set_opacity_by_tex` * Removed ade_all_but_tex and integrated functionality into set_opacity_by_tex. Included a second parameter 'remaining_opacity' to define the opacity value of the remaining tex * Added type hints for `set_opacity_by_tex`. Removed type information in docstring. Improved logic of `set_opacity_by_tex` to reduce redundant calls for tex parts --------- Co-authored-by: Benjamin Hackl <[email protected]>

Co-authored-by: Jason Villanueva <[email protected]>

for more information, see https://pre-commit.ci

MrDiver · 2023-09-11T01:45:09Z

Basic rendering works now

Next steps:

Rendering Submobjects
Abstracting Rendering

for more information, see https://pre-commit.ci

MrDiver · 2023-09-12T21:19:30Z

Newest state suports fully featured 3D rendering and transparency without z fighting or any other artifacts

MrDiver · 2023-09-12T21:20:41Z

TransparencyWorking.mp4

MrDiver · 2023-09-12T21:24:31Z

TODO: There is a bug when you create another circle and set the opacity with set_opacity then the green square will change opacity

for more information, see https://pre-commit.ci

…xperimental

elyanah-aco and others added 30 commits January 20, 2023 12:13

Change links redirecting to dead troubleshooting page (ManimCommunity…

1425c9a

…#3126) * docs: change links redirecting to dead troubleshooting page * Fix typo in FAQ link Co-authored-by: elyanah <[email protected]>

Fixed example using reverse with Write (ManimCommunity#3137)

87e6a0a

Added the fix (ManimCommunity#3106)

262300c

Co-authored-by: Tristan Schulz <[email protected]>

Fix typo in stripUntranslatable.awk (ManimCommunity#3144)

c6ca9ff

Wether -> Whether

Remove actions using self-hosted runners (ManimCommunity#3156)

1a43905

see ManimCommunity#3130

Remove alignment_vect arg in align_to (ManimCommunity#3165)

e20e446

typo(docs): Fix grammar (ManimCommunity#3160)

7b5c593

* typo(docs): Fix grammar * fix typo in source code

Fix docstring of ThreeDCamera get_value_trackers (ManimCommunity#3124)

e884b8b

Without this unpacking values returned from get_value_trackers could have one too many.

Fix deprecation warning from numpy (ManimCommunity#3179)

92b01eb

Fixed extlinks in docs to work with latest version of Sphinx. (ManimC…

27011d6

…ommunity#3186)

CI: update PATH for recent changed in TinyTex (ManimCommunity#3196)

f6a379c

`win32` -> `windows` due to 64-bit binaries

scales x&y before calling ImplicitFunction() (ManimCommunity#3195)

479e7b6

fix(3183): render in named threads, limit condition (ManimCommunity#3191

ca8a77d

) Limit condition to interactive OpenGL mode Co-authored-by: Benjamin Hackl <[email protected]>

Corrected the hinted return type for :func:angle_between_vectors (M…

f2f428f

…animCommunity#3189) * Update space_ops.py * Apply suggestions from code review --------- Co-authored-by: Benjamin Hackl <[email protected]>

store color data (ManimCommunity#3134)

b9784a0

Co-authored-by: Benjamin Hackl <[email protected]>

MrDiver and others added 8 commits September 10, 2023 23:45

Basic Rendering Vmobject works!

d418acc

Co-authored-by: Jason Villanueva <[email protected]>

nothing rendering again

1a821d7

Co-authored-by: Jason Villanueva <[email protected]>

change dtype to f1 float 1 byte

9a94781

Working window rendering with events

5a7da79

[pre-commit.ci] auto fixes from pre-commit.com hooks

b7fe84d

for more information, see https://pre-commit.ci

Working render to numpy array

f73b35d

Merge

f82ec48

[pre-commit.ci] auto fixes from pre-commit.com hooks

d9dd887

for more information, see https://pre-commit.ci

MrDiver and others added 6 commits September 12, 2023 05:08

Submobject rendering and further abstraction - WIP for stroke early drop

388604b

[pre-commit.ci] auto fixes from pre-commit.com hooks

603e712

for more information, see https://pre-commit.ci

Working Shading in 3D many many tries

389c1a1

Working Shading in 3D many many tries

ab44633

Almost working blending, stroke broken

46ba43c

Working Blending and Transparency in one direction

7a7ed42

MrDiver and others added 11 commits September 12, 2023 23:35

Fixed affecting colors bug returns copy instead

115bcf9

Make depth_testing default

d8f261d

[pre-commit.ci] auto fixes from pre-commit.com hooks

95f97b7

for more information, see https://pre-commit.ci

Fix logo .set deprecated usage

df97462

Initializing Window before gl context

17f0204

Fixing svg mobject constructor

8537fd6

experimental transparent stroke shadnig

7e97df4

some formatting and removing unused variables

7f4b287

[pre-commit.ci] auto fixes from pre-commit.com hooks

bffbc22

for more information, see https://pre-commit.ci

add comment

e50b82f

Merge branch 'experimental' of github.com:jsonvillanueva/manim into e…

4fb492c

…xperimental

jsonvillanueva merged commit 4fb492c into ManimCommunity:experimental Oct 25, 2023
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental update #3357

Experimental update #3357

jsonvillanueva commented Sep 4, 2023

MrDiver commented Sep 11, 2023

MrDiver commented Sep 12, 2023

MrDiver commented Sep 12, 2023

MrDiver commented Sep 12, 2023

Experimental update #3357

Experimental update #3357

Conversation

jsonvillanueva commented Sep 4, 2023

Overview: What does this pull request change?

MrDiver commented Sep 11, 2023

MrDiver commented Sep 12, 2023

MrDiver commented Sep 12, 2023

MrDiver commented Sep 12, 2023