Added "tex_bin_dir" config option for specifying a custom TeX binarie… #3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levimcgomes
commented
Sep 2, 2023
| @@ -154,7 +155,10 @@ def is_ffmpeg_working(): | |||
| ), | |||
| ) | |||
| def is_latex_available(): | |||
| path_to_latex = shutil.which("latex") | |||
| if config.get_dir("tex_bin_dir") is not None: | |||
| path_to_latex = config.get_dir("tex_bin_dir") / "latex.exe" | |||
There was a problem hiding this comment.
I've tested this on Windows, and found the ".exe" suffix to be necessary. This might be different in other OS's though, in which case a simple if clause should solve it.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Wouldn't it be more useful to specify the binary directly in that case? |
|
Perhaps. The reason I added an option for the folder instead of for the binary itself is because Manim is supposed to support different ways of rendering LaTeX, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
tex_bin_dirto_config.utils.ManimConfigtex_file_writing.py, to determine the location of both the TeX compiler and the dvisvgm executablemanim/cli/checkhealth/checks.pyto also use this option when determining the presence of LaTeX and dvisvgmMotivation and Explanation: Why and how do your changes improve the library?
This new option allows users to specify a custom directory for the TeX executables, through the
tex_bin_dirconfig, available both in config files and the CLI. When this option is unset, the executables which are found on the PATH will instead be used.Having this option allows users to use Manim with a TeX installation which isn't on their PATH, which is usefull, for instance, when there are multiple TeX installations.
Reviewer Checklist