Skip to content

Commit

Permalink
Revert attempted fix in put_start_and_end_on
Browse files Browse the repository at this point in the history
  • Loading branch information
chopan050 committed Dec 7, 2024
1 parent b8778c2 commit 5b5ae70
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion manim/mobject/geometry/line.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from ..matrix import Matrix # Avoid circular import

AngleQuadrant: TypeAlias = tuple[Literal[-1, 1], Literal[-1, 1]]
"""A tuple of 2 integers which can be either +1 or -1, allowing to select
r"""A tuple of 2 integers which can be either +1 or -1, allowing to select
one of the 4 quadrants of the Cartesian plane.
Let :math:`L_1,\ L_2` be two lines defined by start points
Expand Down
4 changes: 3 additions & 1 deletion manim/mobject/mobject.py
Original file line number Diff line number Diff line change
Expand Up @@ -1776,7 +1776,9 @@ def put_start_and_end_on(self, start: Point3DLike, end: Point3DLike) -> Self:
curr_start, curr_end = self.get_start_and_end()
curr_vect = curr_end - curr_start
if np.all(curr_vect == 0):
# TODO: this makes self.points contain a single point
# TODO: this looks broken. It makes self.points a Point3D instead
# of a Point3D_Array. However, modifying this breaks some tests
# where this is currently expected.
self.points = np.array(start, ndmin=2)
return self
target_vect = np.asarray(end) - np.asarray(start)
Expand Down

0 comments on commit 5b5ae70

Please sign in to comment.