fix windows path to string bug #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osolmaz
approved these changes
Sep 19, 2023
|
Thanks for the correction! |
Sure :-) Thank you so much for the library, I just spent a few days making a very cool video with the voiceover of Azure, and it was extremely convenient! A year ago I did a similar video without your library, and I can sincerely say it saves A LOT of time. I will use this opportunity to say that I think the most important thing now is to make caching available also for the voiceover videos, as exporting it without caching took quite a lot of time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the modified line the Path was changed to a string. In Windows, without this added "str", the sox function throws an error for having a Path argument instead of an str argument (the exception is thrown in sox/core, line 51).