Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set model validation lengths based upon react form maxLength #23262

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set model validation lengths based upon react form maxLength #23262

wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Nov 8, 2024

No description provided.

@kbrock kbrock force-pushed the model_field_length branch 2 times, most recently from d59848f to 0c7e540 Compare November 11, 2024 15:32
@kbrock
Copy link
Member Author

kbrock commented Nov 11, 2024 •
edited
Loading

update:

  • fix syntax error

update:

  • no longer require vm#description
  • rubocop spaces

@kbrock
Copy link
Member Author

kbrock commented Nov 11, 2024

update:

  • authentication no longer requires name

@kbrock kbrock force-pushed the model_field_length branch 2 times, most recently from fde4e05 to 6a295e4 Compare November 19, 2024 14:44
@kbrock kbrock added the security fix Security fix generated by WhiteSource label Nov 19, 2024
@kbrock
Copy link
Member Author

kbrock commented Nov 20, 2024

update:

  • Rebase
  • Remove Authentication#name presence check
  • Zone#name, description length from 50 to 128

update:

  • Fix error MiqAlert#name (mistyped to notes)

@kbrock
Copy link
Member Author

kbrock commented Nov 20, 2024

update:

  • fix merge conflict with hash serialization in Zone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrare agrare Awaiting requested review from agrare agrare is a code owner

@Fryguy Fryguy Awaiting requested review from Fryguy Fryguy is a code owner

Assignees
No one assigned
Labels
security fix Security fix generated by WhiteSource
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kbrock