-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Move provisioning quota calculation methods into MiqTemplate class (pluggable) #22680
base: master
Are you sure you want to change the base?
[WIP] Move provisioning quota calculation methods into MiqTemplate class (pluggable) #22680
Conversation
07ad68d
to
98fa002
Compare
4773e73
to
a78222d
Compare
@miq-bot cross-repo-tests ManageIQ/manageiq-content#737 ManageIQ/manageiq-automation_engine#532 |
From Pull Request: ManageIQ/manageiq#22680
36cd97a
to
6a73a5b
Compare
6a73a5b
to
9d50970
Compare
9d50970
to
9167dd5
Compare
@jaywcarman Sorry, having trouble making out what was changed Is it possible to change this into 2 (or more) commits?
|
@kbrock I'm happy to do so. |
To calculate the quota values, only the request itself (along with an optional flavor_id override) is needed.
Cloud and Infra requests use different default quota calculation logic.
9167dd5
to
b458eaa
Compare
Checked commits jaywcarman/manageiq@47c1c14~...b458eaa with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
From Pull Request: ManageIQ/manageiq#22680
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
This pull request is not mergeable. Please rebase and repush. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
PR set:
Fixes #22641
Move methods making quota calculations for a given request into
MiqTemplate
base class. They can then be overridden in theManageIQ::Providers::CloudManager::Template
subclass (for "cloud" providers), or even in provider plug-in subclasses.Allows an override in
ManageIQ::Providers::IbmCloud::PowerVirtualServers::CloudManager::Template
to fix a bug where it reports 0 cpus for quota.TODO: