Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert settings details tab to use carbon components #9270

Merged

Conversation

liu-samuel
Copy link
Contributor

@liu-samuel liu-samuel commented Sep 20, 2024

New:
Screenshot 2024-11-11 at 12 45 39 PM

Old:
Screenshot 2024-09-20 at 2 58 34 PM

@liu-samuel liu-samuel requested a review from a team as a code owner September 20, 2024 18:58
@GilbertCherrie GilbertCherrie self-assigned this Sep 23, 2024
@liu-samuel liu-samuel force-pushed the settings-region-table-carbon branch 2 times, most recently from 59e4ea0 to 88ca138 Compare September 23, 2024 17:31
Copy link
Member

@GilbertCherrie GilbertCherrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the 2 minor comments, this pr looks good

@Fryguy
Copy link
Member

Fryguy commented Nov 11, 2024

@GilbertCherrie The screenshot shows the venn diagram icon, but I think you picked a different one?

@GilbertCherrie
Copy link
Member

@Fryguy yeah once @liu-samuel updates the icon we can update the screenshots and merge this pr

@GilbertCherrie GilbertCherrie merged commit 8c73066 into ManageIQ:master Nov 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants