-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert settings details tab to use carbon components #9270
Merged
GilbertCherrie
merged 1 commit into
ManageIQ:master
from
liu-samuel:settings-region-table-carbon
Nov 11, 2024
Merged
Convert settings details tab to use carbon components #9270
GilbertCherrie
merged 1 commit into
ManageIQ:master
from
liu-samuel:settings-region-table-carbon
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-samuel
force-pushed
the
settings-region-table-carbon
branch
2 times, most recently
from
September 23, 2024 17:31
59e4ea0
to
88ca138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the 2 minor comments, this pr looks good
liu-samuel
force-pushed
the
settings-region-table-carbon
branch
from
November 6, 2024 20:24
88ca138
to
3370b22
Compare
liu-samuel
force-pushed
the
settings-region-table-carbon
branch
from
November 8, 2024 21:11
3370b22
to
f3af36c
Compare
@GilbertCherrie The screenshot shows the venn diagram icon, but I think you picked a different one? |
@Fryguy yeah once @liu-samuel updates the icon we can update the screenshots and merge this pr |
liu-samuel
force-pushed
the
settings-region-table-carbon
branch
from
November 11, 2024 17:45
f3af36c
to
256b5f6
Compare
GilbertCherrie
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New:
Old: