NoSettings (#369)

LPD8806 missing no settings enhancement
Makuna · Sep 20, 2020 · c7b0c66 · c7b0c66
1 parent a05b708
commit c7b0c66
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/src/internal/Lpd8806ColorFeatures.h b/src/internal/Lpd8806ColorFeatures.h
@@ -26,11 +26,33 @@ License along with NeoPixel.  If not, see
 -------------------------------------------------------------------------*/
 #pragma once
 
-class Lpd88063Elements
+class Lpd88063ElementsNoSettings
+{
+public:
+    typedef NeoNoSettings SettingsObject;
+    static const size_t SettingsSize = 0;
+
+    static void applySettings(uint8_t*, const SettingsObject&)
+    {
+    }
+
+    static uint8_t* pixels(uint8_t* pData)
+    {
+        return pData;
+    }
+
+    static const uint8_t* pixels(const uint8_t* pData)
+    {
+        return pData;
+    }
+};
+
+class Lpd88063Elements : public Lpd88063ElementsNoSettings
 {
 public:
     static const size_t PixelSize = 3; 
 
+
     static uint8_t* getPixelAddress(uint8_t* pPixels, uint16_t indexPixel)
     {
         return pPixels + indexPixel * PixelSize;

diff --git a/src/internal/NeoEsp8266DmaMethod.h b/src/internal/NeoEsp8266DmaMethod.h
@@ -437,7 +437,7 @@ template<typename T_SPEED> class NeoEsp8266DmaMethodBase
     // handle here is the RX_EOF_INT status, which indicate the DMA has sent a buffer whose
     // descriptor has the 'EOF' field set to 1.
     // in the case of this code, the second to last state descriptor
-    volatile static void ICACHE_RAM_ATTR i2s_slc_isr(void)
+    static void ICACHE_RAM_ATTR i2s_slc_isr(void)
     {
         ETS_SLC_INTR_DISABLE();