Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverting handlebars #53

Merged
merged 46 commits into from
Jul 21, 2024
Merged

Reverting handlebars #53

merged 46 commits into from
Jul 21, 2024

Conversation

Lan2u
Copy link
Collaborator

@Lan2u Lan2u commented Jul 19, 2024 •
edited
Loading

Closes #52

Lan2u added 30 commits July 19, 2024 20:32
@Lan2u
Reverting handlebars
8e0d933
@Lan2u
member input selector back to html template
bb47c8c
@Lan2u
Template helpers back to using template strings
0d72cdc
@Lan2u
Continuing to switch back to template strings not handlebars
447c284
@Lan2u
Equipment back to templates
512511b
@Lan2u
Revert auth
d25949b
@Lan2u
area commands -> templates
9cc74bd
@Lan2u
Revert equipment forms to templates
70ac0e2
@Lan2u
Revert member number linking form to templates
c1083e0
@Lan2u
Update equipment to be more concise using pipe
fdcdee2
@Lan2u
Revert members command
b3a5f9b
@Lan2u
Revert super-user forms to handlebars
0c58ed2
@Lan2u
Revert trainers back to html template
b9efc7e
@Lan2u
Revert http section back to html templates
cf694bc
@Lan2u
all equipment -> back to html templates
854c21e
@Lan2u
Update equipment render to be nicer to read
3a67374
@Lan2u
area render -> html template
6426158
@Lan2u
render areas -> html template
577e461
@Lan2u
Try allowing UUID in html templates
30b56c4
@Lan2u
Use UUID rather than string so that we know it doesn't need sanitised
f3cc92f
@Lan2u
Remove unneeded sanitise
bc9e6ec
@Lan2u
failed imports -> back to html template
e51b66d
@Lan2u
Allow empty string in html templates unsanitised
c168849
@Lan2u
Landing page back to html template
027a3eb
@Lan2u
Render events back to html template
7f7ab54
@Lan2u
member page -> html template
cfbcdea
@Lan2u
members -> html template
322f743
@Lan2u
super users back to html template
bd78607
@Lan2u
Export HtmlSubstitution type and use UUID in more places to fix type …
3028a4b 
…errors around html templating
@Lan2u
Use UUID in more places so we can trace that its safe for templating
0266518
Lan2u
Lan2u commented Jul 20, 2024
View reviewed changes
src/queries/areas/render.ts Outdated Show resolved Hide resolved
Lan2u
Lan2u commented Jul 20, 2024
View reviewed changes
src/queries/landing/render.ts Outdated Show resolved Hide resolved
Lan2u
Lan2u commented Jul 20, 2024
View reviewed changes
src/queries/landing/render.ts Outdated Show resolved Hide resolved
Lan2u
Lan2u commented Jul 20, 2024
View reviewed changes
src/queries/member/render.ts Outdated Show resolved Hide resolved
Lan2u
Lan2u commented Jul 20, 2024
View reviewed changes
src/templates/avatar.ts Outdated Show resolved Hide resolved
@Lan2u Lan2u requested review from chromy and erkannt July 20, 2024 20:22
@Lan2u Lan2u marked this pull request as ready for review July 20, 2024 20:22
@Lan2u
Copy link
Collaborator Author

Lan2u commented Jul 20, 2024

If anything on the snaglist here #54 is a regression please lmk and I'll fix

@Lan2u Lan2u merged commit fc2f84d into main Jul 21, 2024
5 checks passed
@Lan2u Lan2u deleted the revert_handlebars branch July 21, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chromy chromy Awaiting requested review from chromy

@erkannt erkannt Awaiting requested review from erkannt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert handlebars
1 participant
@Lan2u