Skip to content

Commit

Permalink
Lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
Lan2u committed Oct 12, 2024
1 parent 67125d3 commit 65d7c23
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/training-sheets/google.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ const extractScore = (
});
};

export const extractEmail = (
const extractEmail = (
rowValue: string | undefined | null
): O.Option<string> => {
if (!rowValue) {
Expand All @@ -89,7 +89,7 @@ export const extractEmail = (
return O.some(rowValue.trim());
};

export const extractMemberNumber = (
const extractMemberNumber = (
rowValue: string | number | undefined | null
): O.Option<number> => {
if (!rowValue) {
Expand Down
2 changes: 1 addition & 1 deletion src/training-sheets/legacy-training-import.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {extractTimestamp} from './google';
import {EventOfType} from '../types/domain-event';
import {Actor} from '../types/actor';

export type ImportDeps = Pick<
type ImportDeps = Pick<
Dependencies,
'logger' | 'getAllEventsByType' | 'commitEvent'
>;
Expand Down
16 changes: 7 additions & 9 deletions tests/temp_test_legacy_import.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import {TaskEither} from 'fp-ts/lib/TaskEither';
import {StatusCodes} from 'http-status-codes';

import {legacyTrainingImport} from '../src/training-sheets/legacy-training-import';
import { DomainEvent, EventName, EventOfType } from '../src/types/domain-event';
import { FailureWithStatus } from '../src/types/failure-with-status';
import { Resource } from '../src/types/resource';
// import { EventName, EventOfType } from './src/types/domain-event';
// import { FailureWithStatus } from './src/types/failure-with-status';
import {DomainEvent, EventName, EventOfType} from '../src/types/domain-event';
import {FailureWithStatus} from '../src/types/failure-with-status';
import {Resource} from '../src/types/resource';

async function main() {
await legacyTrainingImport(
Expand Down Expand Up @@ -42,13 +40,13 @@ async function main() {
{
logger: pino(),
getAllEventsByType: function <T extends EventName>(
eventType: T
_eventType: T
): TaskEither<FailureWithStatus, ReadonlyArray<EventOfType<T>>> {
return TE.right([]);
},
commitEvent: function (
resource: Resource,
lastKnownVersion
_resource: Resource,
_lastKnownVersion
): (
event: DomainEvent
) => TaskEither<
Expand All @@ -61,4 +59,4 @@ async function main() {
);
}

main();
void main();

0 comments on commit 65d7c23

Please sign in to comment.