-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update system information #3337
Update system information #3337
Conversation
- Add ELECTRON_ENABLE_GPU - Remove docker version - Differentiation between installed and used node version
Since we display system information in the console, it is easy to overlook this important line.
Merged. When running it on my pi4 I get this in the error log (this error already happened with the original PR too):
SysInfo is shown nevertheless:
|
/home/rejas/MagicMirror/node_modules/systeminformation/lib/system.js:64 |
That is strange. I have a Pi4 here but have yet to set it up. I probably won't be able to do that in the next few days. Could it be that systeminformation uses libraries that are incompatible with the Raspi? Has anyone else run it on a Raspi? |
will try it on raspi later ... |
I can reproduce this error on a raspi with arm64 (but not on arm). It is caused by the line So I think they are getting these info's in a thread and trying this until it succeeds. It is really ugly because the above error is thrown 7 times when starting. Will dig in the systeminformation code later. It happens only when running |
Thanks for looking it up! Until systimformation fixes that, maybe we could add an if condition that only outputs the system info for non-arm64 systems. Of course, that wouldn't be great, as a lot of users probably use arm64. |
I'm working on a approach requesting only the needed information. Maybe that will solve the issue. I' preparing a PR. |
I found no solution for the arm64 problem. I thought of a timing problem but delaying the call (up to 15 sec.) did not change anything. |
Hopefully this solves the problem with arm64 (reported in PR MagicMirrorOrg#3337).
Can please someone check PR #3338 on arm64? |
only 3 errors instead of 7 before ... |
Strange, but a step forward. Maybe you can gradually reduce the information requested to find out which ones are causing the problems? const staticData = await si.get({
system: "manufacturer, model, raspberry, virtual",
osInfo: "platform, distro, release, arch",
versions: "kernel, node, npm, pm2"
}); |
|
Okay, what now? Comment out system and osInfo and commit? |
no, let us wait, there is much time until next release, at the moment I have no idea. It is really strange that this occurs only on |
by excluding them from global error handling, see discussions in #3337
Hopefully this solves the problem with arm64 (reported in PR #3337).
I have now also looked at the issue on a Pi 4 and can only confirm what you have already found out and have no direct solution. I have found an existing open issue (sebhildebrandt/systeminformation#873) and have added my findings there. If anyone finds out anything else, they could add it there. If this is fixed, we could reverse the changes from #3349. One more note: I have noticed that the "raspberry" field seems never to be filled. I have opened a new issue for this: sebhildebrandt/systeminformation#881. |
## [2.27.0] - 2024-04-01 Thanks to: @bugsounet, @crazyscot, @illimarkangur, @jkriegshauser, @khassel, @KristjanESPERANTO, @Paranoid93, @rejas, @sdetweil and @vppencilsharpener. This release marks the first release without Michael Teeuw (@MichMich). A very special thanks to him for creating MagicMirror and leading the project for so many years. For more info, please read the following post: [A New Chapter for MagicMirror: The Community Takes the Lead](https://forum.magicmirror.builders/topic/18329/a-new-chapter-for-magicmirror-the-community-takes-the-lead). ### Added - Output of system information to the console for troubleshooting (#3328 and #3337), ignore errors under aarch64 (#3349) - [chore] Add `eslint-plugin-package-json` to lint the `package.json` files (#3368) - [weather] `showHumidity` config is now a string describing where to show this element. Supported values: "wind", "temp", "feelslike", "below", "none". (#3330) - electron-rebuild test suite for electron and 3rd party modules compatibility (#3392) - Create MM² icon and attach it to electron process (#3407) ### Updated - Update updatenotification (update_helper.js): Recode with pm2 library (#3332) - Removing lodash dependency by replacing merge by spread operator (#3339) - Use node prefix for build-in modules (#3340) - Rework logging colors (#3350) - Update pm2 to v5.3.1 with no allow-ghsas (#3364) - [chore] Update husky and let lint-staged fix ESLint issues - [chore] Update dependencies including electron to v29 (#3357) and node-ical - Update translations for estonian (#3371) - Update electron to v29 and update other dependencies - [calendar] fullDay events over several days now show the left days from the first day on and 'today' on the last day - Update layout of current weather indoor values ### Fixed - Correct apibase of weathergov weatherprovider to match documentation (#2926) - Worked around several issues in the RRULE library that were causing deleted calender events to still show, some initial and recurring events to not show, and some event times to be off an hour. (#3291) - Skip changelog requirement when running tests for dependency updates (#3320) - Display precipitation probability when it is 0% instead of blank/empty (#3345) - [newsfeed] Suppress unsightly animation cases when there are 0 or 1 active news items (#3336) - [newsfeed] Always compute the feed item URL using the same helper function (#3336) - Ignore all custom css files (#3359) - [newsfeed] Fix newsfeed stall issue introduced by #3336 (#3361) - Changed `log.debug` to `log.log` in `app.js` where logLevel is not set because config is not loaded at this time (#3353) - [calendar] deny fetch interval < 60000 and set 60000 in this case (prevent fetch loop failed) (#3382) - added message in case where config.js is missing the module.export line PR #3383 - Fixed an issue where recurring events could extend past their recurrence end date (#3393) - Don't display any `npm WARN <....>` on install (#3399) - Fixed move suncalc dependency to production from dev, as it is used by clock module - [compliments] Fix mirror not responding anymore when no compliments are to be shown (#3385) ### Deleted - Unneeded file headers (#3358) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Teeuw <[email protected]> Co-authored-by: Kristjan ESPERANTO <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karsten Hassel <[email protected]> Co-authored-by: Ross Younger <[email protected]> Co-authored-by: Bugsounet - Cédric <[email protected]> Co-authored-by: jkriegshauser <[email protected]> Co-authored-by: illimarkangur <[email protected]> Co-authored-by: sam detweiler <[email protected]> Co-authored-by: vppencilsharpener <[email protected]> Co-authored-by: Paranoid93 <[email protected]>
Electron mode
Before
After
server mode
Before
After