OriBF: Move Ori and the Blind Forest to worlds_disabled. (Archipela…

…goMW#1906) * OriBF: Move Ori and the Blind Forest to `worlds_disabled/` * Add readme for `worlds_disabled` folder * fix link * fix link 2 * Remove useless comment Co-authored-by: el-u <[email protected]> --------- Co-authored-by: el-u <[email protected]>
MadiMadsen · Jun 29, 2023 · c9fb443 · c9fb443
1 parent 3252992
commit c9fb443
Show file tree

Hide file tree

Showing 10 changed files with 20 additions and 18 deletions.
diff --git a/test/general/TestReachability.py b/test/general/TestReachability.py
@@ -2,7 +2,6 @@
 
 from BaseClasses import CollectionState
 from worlds.AutoWorld import AutoWorldRegister
-
 from . import setup_solo_multiworld
 
 
@@ -34,25 +33,23 @@ class TestBase(unittest.TestCase):
 
     def testDefaultAllStateCanReachEverything(self):
         for game_name, world_type in AutoWorldRegister.world_types.items():
-            # Final Fantasy logic is controlled by finalfantasyrandomizer.com
-            if game_name not in {"Ori and the Blind Forest"}:  # TODO: fix Ori Logic
-                unreachable_regions = self.default_settings_unreachable_regions.get(game_name, set())
-                with self.subTest("Game", game=game_name):
-                    world = setup_solo_multiworld(world_type)
-                    excluded = world.exclude_locations[1].value
-                    state = world.get_all_state(False)
-                    for location in world.get_locations():
-                        if location.name not in excluded:
-                            with self.subTest("Location should be reached", location=location):
-                                self.assertTrue(location.can_reach(state), f"{location.name} unreachable")
+            unreachable_regions = self.default_settings_unreachable_regions.get(game_name, set())
+            with self.subTest("Game", game=game_name):
+                world = setup_solo_multiworld(world_type)
+                excluded = world.exclude_locations[1].value
+                state = world.get_all_state(False)
+                for location in world.get_locations():
+                    if location.name not in excluded:
+                        with self.subTest("Location should be reached", location=location):
+                            self.assertTrue(location.can_reach(state), f"{location.name} unreachable")
 
-                    for region in world.get_regions():
-                        if region.name not in unreachable_regions:
-                            with self.subTest("Region should be reached", region=region):
-                                self.assertTrue(region.can_reach(state))
+                for region in world.get_regions():
+                    if region.name not in unreachable_regions:
+                        with self.subTest("Region should be reached", region=region):
+                            self.assertTrue(region.can_reach(state))
 
-                    with self.subTest("Completion Condition"):
-                        self.assertTrue(world.can_beat_game(state))
+                with self.subTest("Completion Condition"):
+                    self.assertTrue(world.can_beat_game(state))
 
     def testDefaultEmptyStateCanReachSomething(self):
         for game_name, world_type in AutoWorldRegister.world_types.items():

diff --git a/worlds_disabled/README.md b/worlds_disabled/README.md
@@ -0,0 +1,5 @@
+## Folder Purpose
+
+This folder is for already merged worlds that are unmaintained and currently broken. If you are interested in fixing and
+stepping up as maintainer for any of these worlds, please review the [world maintainer](/docs/world%20maintainer.md)
+documentation.
diff --git a/worlds/oribf/Items.py → worlds_disabled/oribf/Items.py b/worlds/oribf/Items.py → worlds_disabled/oribf/Items.py
diff --git a/worlds/oribf/Locations.py → worlds_disabled/oribf/Locations.py b/worlds/oribf/Locations.py → worlds_disabled/oribf/Locations.py
diff --git a/worlds/oribf/Options.py → worlds_disabled/oribf/Options.py b/worlds/oribf/Options.py → worlds_disabled/oribf/Options.py
diff --git a/worlds/oribf/Regions.py → worlds_disabled/oribf/Regions.py b/worlds/oribf/Regions.py → worlds_disabled/oribf/Regions.py
diff --git a/worlds/oribf/Rules.py → worlds_disabled/oribf/Rules.py b/worlds/oribf/Rules.py → worlds_disabled/oribf/Rules.py
diff --git a/worlds/oribf/RulesData.py → worlds_disabled/oribf/RulesData.py b/worlds/oribf/RulesData.py → worlds_disabled/oribf/RulesData.py
diff --git a/worlds/oribf/Types.py → worlds_disabled/oribf/Types.py b/worlds/oribf/Types.py → worlds_disabled/oribf/Types.py
diff --git a/worlds/oribf/__init__.py → worlds_disabled/oribf/__init__.py b/worlds/oribf/__init__.py → worlds_disabled/oribf/__init__.py