Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI workflow #313

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Improve CI workflow #313

merged 5 commits into from
Jul 8, 2024

Conversation

FantasyTeddy
Copy link
Contributor

This is the implementation of the changes discussed in #311:

  • Extracting the cargo fmt and cargo clippy steps into their own jobs.
    • @grtcdr: What do you think? Is this OK, or should we combine the two jobs?
  • Fail clippy on warnings (required some minor code changes).
  • Execute the "Test" and "Doctor" change on all platforms that support it.

Additionally, I removed the strip variable from the matrix, because it was never used.

@FantasyTeddy
Copy link
Contributor Author

The "GNU/Linux x86_64 (x86_64-unknown-linux-gnu)" job seems to fail the "Doctor" stage because of an actual bug in libmacchina: https://github.com/Macchina-CLI/libmacchina/blob/main/src/linux/mod.rs#L831

@grtcdr
Copy link
Member

grtcdr commented Jul 8, 2024

This looks good to me, let's merge :)

I've added a safeguard to stop the program from crashing on Linux in Macchina-CLI/libmacchina@30abf25.

@grtcdr grtcdr merged commit 31874e3 into Macchina-CLI:main Jul 8, 2024
12 of 13 checks passed
@FantasyTeddy FantasyTeddy deleted the improve-ci branch July 8, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants