Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge UserCleaner hotfixes back to dev #721

Closed
wants to merge 6 commits into from
Closed

Merge UserCleaner hotfixes back to dev #721

wants to merge 6 commits into from

Conversation

Splines
Copy link
Member

@Splines Splines commented Dec 8, 2024

Here, we merge the hotfixes on the main branch back to dev.

Splines and others added 6 commits May 31, 2024 00:11
Merge pull request #646 from MaMpf-HD/dev
Merge pull request #661 from MaMpf-HD/dev
Merge pull request #679 from MaMpf-HD/dev
* Deal with registration edge cases in UserCleaner

* Replace `last_sign_in_at` by `current_sign_in_at`

* Simplify inactive_users method via usage of scopes

* Add another scope for recently active users
* Fix unknown user variable after deletion

* Adjust other occurrence of method

* Update failing user cleaner jobs with new method signature

* Expect user email for deletion mail

* Fix `with` syntax
@Splines Splines self-assigned this Dec 8, 2024
@Splines Splines marked this pull request as draft December 8, 2024 15:24
@Splines Splines closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants