Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Style/ArrayIntersect on one line #720

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Disable Style/ArrayIntersect on one line #720

merged 1 commit into from
Dec 3, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Dec 3, 2024

See it in the Rubocop docs:

This cop cannot guarantee that array1 and array2 are actually arrays while method intersect? is for arrays only.

Here, we deal with ActiveRecord objects that are not arrays, so we shouldn't use this. That's why I disable the lint here.

@Splines
Copy link
Member Author

Splines commented Dec 3, 2024

I will skip the tests here as the only change is adding a comment, so no code changed.

@Splines Splines merged commit 8196e38 into dev Dec 3, 2024
2 of 4 checks passed
@Splines Splines deleted the lint/rubocop branch December 3, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants