Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gems #712

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Update Gems #712

merged 2 commits into from
Dec 1, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Nov 24, 2024

As usual, update Ruby Gems. Since I pinned all versions in #680, I don't expect any breaking changes here (we only do a minor update with this PR).


Warning

Warning: Mobility v1.3.x includes potentially backwards-incompatible changes
for jsonb/hstore backends.

We don't use this backend, right? At least a search for hstore or jsonb doesn't reveal anything in the MaMpf codebase.

@Splines Splines added the dependencies Pull requests that update a dependency file label Nov 24, 2024
@Splines Splines self-assigned this Nov 24, 2024
@Splines Splines changed the base branch from main to dev November 24, 2024 00:49
@Splines Splines marked this pull request as draft November 24, 2024 00:54
During this, I updated the Gems again
@fosterfarrell9
Copy link
Collaborator

We don't use this backend, right? At least a search for hstore or jsonb doesn't reveal anything in the MaMpf codebase.

That is correct, we do not use this.

Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@e97ec8a). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #712   +/-   ##
======================================
  Coverage       ?   54.30%           
======================================
  Files          ?      170           
  Lines          ?     7348           
  Branches       ?        0           
======================================
  Hits           ?     3990           
  Misses         ?     3358           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit 2e4f26d into dev Dec 1, 2024
6 of 8 checks passed
@Splines Splines deleted the deps/update-gems branch December 1, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants