Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init dependencies (deps) Just commands #711

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Init dependencies (deps) Just commands #711

merged 1 commit into from
Nov 26, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Nov 24, 2024

We introduce new just commands to ease updating of dependencies, which we want to do regularly with every release.

@Splines Splines added the dependencies Pull requests that update a dependency file label Nov 24, 2024
@Splines Splines self-assigned this Nov 24, 2024
@Splines Splines changed the title Init deps commands vis Just Init dependencies (deps) Just commands Nov 24, 2024
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely! Also, thanks for the comment on changing the access rights for the node_modules folder.

@fosterfarrell9 fosterfarrell9 self-requested a review November 25, 2024 11:14
Copy link
Collaborator

@fosterfarrell9 fosterfarrell9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@8d58aea). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #711   +/-   ##
======================================
  Coverage       ?   54.30%           
======================================
  Files          ?      170           
  Lines          ?     7348           
  Branches       ?        0           
======================================
  Hits           ?     3990           
  Misses         ?     3358           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit ce83dc3 into dev Nov 26, 2024
4 checks passed
@Splines Splines deleted the deps/init-deps-just branch November 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants