-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lecture edit page if active term is not set #683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- Maybe you can add an end-to-end test to ensure that the lecture#edit page looks as expected? (instead of showing an error?)
- And maybe even add a unit test for the
lecture.stale?
method to ensure it gives proper results even in the case where we just have a lecture and not an active term set.
I added unit tests for |
Co-authored-by: Splines <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that you'll have to approve the tests such that they can run through before merging via Squash and merge
.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #683 +/- ##
======================================
Coverage ? 53.86%
======================================
Files ? 157
Lines ? 6645
Branches ? 0
======================================
Hits ? 3579
Misses ? 3066
Partials ? 0 ☔ View full report in Codecov by Sentry. |
This fixes #682 by adding the missing case in the
older_than?
method in theLecture
model.