Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use VSCode ESLint experimental flag anymore #662

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Jul 7, 2024

Changes

  • Don't use ESLint experimental flag anymore (it's now in the official plugin version)
  • Add the .docker folder to hidden folders
  • Remove custom Ruby LSP command. This was an attempt to mitigate Option to disable ruby-lsp-rails server-dependent addon features [low-prio] Shopify/ruby-lsp-rails#382, however it did not work (or rather was too much effort), so we just don't use the few Ruby LSP server-dependent features (for that we would have to run it inside docker containers) and stick with the static code analysis with is sufficient for us.

@Splines Splines added the ide Related to integrated developer environments, e.g. VSCode etc. label Jul 7, 2024
@Splines Splines self-assigned this Jul 7, 2024
@Splines Splines marked this pull request as ready for review July 7, 2024 23:33
@Splines Splines requested a review from fosterfarrell9 July 7, 2024 23:33
@Splines
Copy link
Member Author

Splines commented Jul 7, 2024

Missing anything in terms of settings in VSCode? This might be a good time to add respective settings here.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.64%. Comparing base (6bde35d) to head (febae5a).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #662   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files         308      308           
  Lines        9386     9386           
=======================================
  Hits         6255     6255           
  Misses       3131     3131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Splines Splines merged commit e7d6053 into dev Jul 9, 2024
9 of 11 checks passed
@Splines Splines deleted the fix/vscode-settings branch July 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ide Related to integrated developer environments, e.g. VSCode etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants