Fix broken interactions controller #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splines
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
For posterity: current_ability docsstrings are available here. The change in this PR makes sense according to the CanCanCan docs.
I confirm that the /interactions route now works again in the frontend 🎉
Proposal: it'd be great to put PRs in context as much as possible. E.g. for this PR, I had to go back to basecamp to figure out which button in the frontend I should click to verify the code is working. This would be nice to have available in the PR description itself (I've edited it).
|
Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking the
Export statisticsbutton in the admin view (corresponding to the/interactionsroute), we got an error. In this PR we fix the broken interactions controller by adding the missingcurrent_abilitymethod.