Remove GitHub Pull request templates #626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the current PR template for bug fixes, features etc. During the last year we have never used it for PRs as it oftentimes didn't fit to our changes and the real situation. E.g. most PRs don't introduce "breaking changes" and it's not clear what "breaking" is in the first place as our user base are students who will be presented with a new web UI, so "breaking" could mean that a button was rearranged. Despite not using this template, I feel like we still managed to successfully summarize in PRs what they did and what to watch out for in reviews. That's why we remove the template with this PR such that we don't have to delete the text every time we create a new PR.
Note that we have also added GitHub Actions check in the meantime such that linting is automatically verified in our pipeline. We will do so as well with cypress tests and unit tests in the future, such that we don't have to checkmark it here and can instead rely on real code execution.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: