Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub Pull request templates #626

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

Splines
Copy link
Member

@Splines Splines commented Apr 24, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This is the current PR template for bug fixes, features etc. During the last year we have never used it for PRs as it oftentimes didn't fit to our changes and the real situation. E.g. most PRs don't introduce "breaking changes" and it's not clear what "breaking" is in the first place as our user base are students who will be presented with a new web UI, so "breaking" could mean that a button was rearranged. Despite not using this template, I feel like we still managed to successfully summarize in PRs what they did and what to watch out for in reviews. That's why we remove the template with this PR such that we don't have to delete the text every time we create a new PR.

Note that we have also added GitHub Actions check in the meantime such that linting is automatically verified in our pipeline. We will do so as well with cypress tests and unit tests in the future, such that we don't have to checkmark it here and can instead rely on real code execution.

  • Please check if the PR fulfills these requirements

    • E2E Tests for the changes have been added via Cypress
    • Meaningful rspec tests have been added
    • Docs have been added / updated
  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@Splines Splines self-assigned this Apr 24, 2024
@Splines Splines requested a review from fosterfarrell9 April 24, 2024 08:47
@Splines Splines merged commit 2497d48 into dev Apr 25, 2024
3 checks passed
@Splines Splines deleted the github/remove-pr-template branch April 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants