Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous Release 1.12.0 #624

Merged
merged 14 commits into from
Apr 27, 2024
Merged

Continuous Release 1.12.0 #624

merged 14 commits into from
Apr 27, 2024

Conversation

Splines
Copy link
Member

@Splines Splines commented Apr 17, 2024

No description provided.

fosterfarrell9 and others added 10 commits April 9, 2024 19:24
* whitelist editor_ids as parameter only for admins

* add helpdesk informing about inability to change editors

* remove unnecessry hash brackets

* fix typos

* put hash in one line

* remove obsolete parameter

* add helpdesk to cSpell
* Remove unused config files

* Move `eslint` config file to `.config` directory

* Upgrade rubocop version

You will have to run `bundle install` locally.

* Move rubocop and erblint config to `.config` folder

* Add Readme to `.config` directory

* Move `coffeelint` config files to `.config/` folder

* Fix config directory in linter workflow

* Upgrade ESLint version to `9.0.0`

* Fix wording in eslint config comment

* Delete unused `.rspec`

* Remove `.coffeelint.json` config

* Update `.config` Readme

* Fix relative path in rubocop config
* Update Rubocop (and plugins) to latest versions

* Autocorrect safe cops

One rule was disabled since we don't want to alter already performed
migrations.

* Autocorrect unsafe cops

Special care is needed for `tag.rb` around line 190.
The autofix did not produce a valid result, I had to put extra
curly braces around that line as we want to push an object to the array.

* Remove unnecessary Unique validation RuboCop TODO

They probably got unnecessary due to the update of RuboCop, though I
haven't looked into their changelog to confirm.
Splines and others added 4 commits April 24, 2024 09:36
* Remove emergency link fields from database

* Remove emergency-link related code
* Upgrade Rails to v7.1 and run `bundle update`

See the upgrade guide here:
https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html

* Use older version of `html-parser` for `thredded`

See thredded/thredded#979

* Use new `config.autoload_lib` in Rails 7.1

See https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#config-autoload-lib-and-config-autoload-lib-once

Eager loading is on by default for production.

* Remove unused app environment variables usage

The file `config/app_environment_variables.rb` does not exist in our
codebase anymore.

* Run `bin/rails app:update` to update configurations

* Add new framework defaults for Rails 7.1 file

* Update `listen` gem version

This was done because `bin/rails app:update` failed with:
** Execute app:update:active_storage
       rails  active_storage:update
bin/rails aborted!
Gem::LoadError: can't activate listen (~> 3.5), already activated listen-3.0.8.
Make sure all dependencies are added to Gemfile.

* Add TODO note for upcoming serialize change

* Reduce new framework defaults list

* Add migrations introduced by rails update task

* Remove unneeded ActiveStorage migrations

* Remove defaults for sha-256 as we are unaffected

* Use new Rails 7.1 defaults

* Fix TODO rubocop warning

* Update bundler version to 2.5.9

You can do so locally via `bundle update --bundler`

* Remove unnecessary entries in `Gemfile.lock`

Performed automatically via `bundle install`.

* Address `Passing the coder as positional arg` deprecation

This is a followup to rails/rails#47463

* add yaml coder explicitly for serializing arrays

* Migrate from globalize to mobility due to serialization warnings

* Update gem lockfile to include `mobility`

`bundle install` also removed globalize automatically for us.

* Add `I18nLocaleAccessors` as replacement for `globalize_attribute_names`

* Remove obsolete comment regarding `globalize`

* Fix Rails `secrets` deprecation warning (Devise)

This is due to heartcombo/devise#5644.

* Use `install_folder` in cypress on rails

`cypress_folder` is deprecated as config option

---------

Co-authored-by: fosterfarrell9 <[email protected]>
* Rewrite the Readme with more recent screenshots

* Delete unused images

* Improve wording in Readme

* Use iconography for feature list

* Add footer to Readme

* Redact header line

* Unify screenshot summary titles

* Improve wording in about section

* Address wording according to review

* Make distinction to other platforms more clear
@Splines Splines marked this pull request as ready for review April 26, 2024 13:55
@Splines Splines requested a review from fosterfarrell9 April 26, 2024 13:55
@Splines Splines merged commit 9632ccf into main Apr 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants