Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only allow admins to change course editors #610

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

fosterfarrell9
Copy link
Collaborator

Only admins can update the editors of a course, the course editors themselves can't do this. Until now, this was a little inconsequentially only realized in the view by leaving out the corresponding form. This PR whitelists the editor_ids parameter only for admins and adds a helpdesk.

@fosterfarrell9 fosterfarrell9 changed the title Policy/course editor change only for admins Course editor change only for admins Apr 7, 2024
app/controllers/courses_controller.rb Outdated Show resolved Hide resolved
config/locales/de.yml Outdated Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
app/controllers/courses_controller.rb Show resolved Hide resolved
@Splines Splines changed the title Course editor change only for admins Only allow admins to change course editors Apr 8, 2024
app/views/courses/_basics.html.erb Outdated Show resolved Hide resolved
@Splines
Copy link
Member

Splines commented Apr 9, 2024

Use "squash and merge" to merge into dev

@fosterfarrell9 fosterfarrell9 merged commit 518de4e into dev Apr 9, 2024
3 checks passed
@fosterfarrell9 fosterfarrell9 deleted the policy/course-editor-change-only-for-admins branch April 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants