Init default settings/extensions for VSCode #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterfarrell9
previously approved these changes
Dec 13, 2023
Also do not use deprecated flags in new VSCode version.
Splines
added a commit
that referenced
this pull request
Dec 19, 2023
* Init new ESLint config to lint .js and .js.erb files * Add default settings/extensions for VSCode (maybe also something for another PR?) * Add ESLint to CI/CD * Introduce dummy changes to see ESLint in action * Fix wrong fetch depth for checkout action * Remove unnecessary "--" to pass arguments * Outsource retrieval of changed files to reusable action * Correct location of reusable action * Fix further stuff related to GitHub action * Clean up GitHub Actions files * Cache global yarn cache directory * Remove VSCode specific settings in favor of #569 * Revert "Introduce dummy changes to see ESLint in action" This reverts commit cdf3473.
fosterfarrell9
approved these changes
Dec 19, 2023
Splines
added a commit
that referenced
this pull request
Jan 6, 2024
* Init new ESLint config to lint .js and .js.erb files * Add default settings/extensions for VSCode (maybe also something for another PR?) * Add ESLint to CI/CD * Introduce dummy changes to see ESLint in action * Fix wrong fetch depth for checkout action * Remove unnecessary "--" to pass arguments * Outsource retrieval of changed files to reusable action * Correct location of reusable action * Fix further stuff related to GitHub action * Clean up GitHub Actions files * Cache global yarn cache directory * Remove VSCode specific settings in favor of #569 * Revert "Introduce dummy changes to see ESLint in action" This reverts commit cdf3473.
Splines
added a commit
that referenced
this pull request
Jan 6, 2024
* Init default settings/extensions for VSCode * Add further settings * Improve "format on save" options Also do not use deprecated flags in new VSCode version. * Remove trailing comma in settings.json * Enable ESLint as formatter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a default
settings.jsonfor common settings in the code editor VSCode the whole team might benefit from, e.g. common configurations for linters, word wrapping etc. (A future PR will introducejustfor common command-line commands).It also includes a file
extensions.jsonwith useful extensions, e.g. the language server for Ruby (so that Rubocop can run in the background and you get IntelliSense for Ruby code), the ESLint plugin to lint javascript etc.The respective configuration for ESLint is provided in #568
For reviewers
You might want to merge #568 into your local copy of this branch, such that you have a valid ESLint configuration and can check that it auto-lints your files. (To reset afterwards, use
git reset HEAD --hard # will erase ALL your local changesor something like this).