Track last sign in date #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## mampf-next #553 +/- ##
==============================================
+ Coverage 66.51% 66.52% +0.01%
==============================================
Files 311 311
Lines 9423 9426 +3
==============================================
+ Hits 6268 6271 +3
Misses 3155 3155
|
Splines
requested changes
Nov 6, 2023
Splines
requested changes
Nov 12, 2023
Splines
approved these changes
Nov 12, 2023
fosterfarrell9
deleted the
feature/add_last_sign_in_date_to_user_model
branch
Splines
pushed a commit
that referenced
this pull request
Jan 6, 2024
* add trackable module to devise * disable IP adress logging in trackable module of devise * extend comment to explain better what happens * remove redundant lines in comment
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of a later PR that will allow us to remove users that have not logged in for a very long time (see #532), we add tracking of the last sign in date. This is done via Devise's
:trackablemodule. By default, this also stores IP adresses, which we do not want for GDPR reasons, so we make sure that the default is overridden and no IP data are stored.