Fix query for unseen news popups

MaMpf-HD · Sep 13, 2023 · d510971 · d510971
1 parent 69f4159
commit d510971
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/app/controllers/news_popups_controller.rb b/app/controllers/news_popups_controller.rb
@@ -8,10 +8,10 @@ def index
   private
 
     def unseen_news_popups
-      HasSeenNewsPopup
-        .where(user: current_user)
-        .left_outer_joins(:news_popup)
-        .select('news_popups.name', 'news_popups.active')
-        .where(news_popups: { active: true })
+      NewsPopup
+        .where(active: true)
+        .where.not(id: HasSeenNewsPopup
+                            .where(user: current_user)
+                            .pluck(:news_popup_id))
     end
 end