Fix other Naming/ cops (1 still left open)

app/abilities/medium_ability.rb

@@ -18,7 +18,7 @@ def initialize(user)
 
     can [:edit, :update, :enrich, :publish, :destroy, :cancel_publication,
          :add_item, :add_reference, :add_screenshot, :remove_screenshot,
-         :import_script_items, :import_manuscript, :get_statistics,
+         :import_script_items, :import_manuscript, :statistics,
          :render_medium_tags, :fill_quizzable_area,
          :fill_reassign_modal], Medium do |medium|
       user.can_edit?(medium)

app/assets/javascripts/media.coffee

@@ -378,7 +378,7 @@ $(document).on 'turbolinks:load', ->
 
   $(document).on 'click', '#showMediaStatistics', ->
     mediumId = $(this).data('medium')
-    $.ajax Routes.get_statistics_path(mediumId),
+    $.ajax Routes.statistics_path(mediumId),
       type: 'GET'
       dataType: 'script'
     return

app/controllers/main_controller.rb

@@ -10,7 +10,7 @@ def current_ability
 
   def home
     cookies[:locale] = current_user.locale if user_signed_in?
-    get_announcements
+    announcements
   end
 
   def error
@@ -43,7 +43,7 @@ def start
                                                                    :term)
                                        .sort
     end
-    get_announcements
+    announcements
     @talks = current_user.talks.includes(lecture: :term)
                          .select { |t| t.visible_for_user?(current_user) }
                          .sort_by do |t|
@@ -60,7 +60,7 @@ def check_for_consent
       redirect_to consent_profile_path unless current_user.consents
     end
 
-    def get_announcements # rubocop:todo Naming/AccessorMethodName
+    def announcements
       @announcements = Announcement.where(on_main_page: true, lecture: nil)
                                    .pluck(:details)
                                    .join('<hr class="my-3" w-100>')

app/controllers/media_controller.rb

@@ -405,7 +405,7 @@ def register_download
     head :ok
   end
 
-  def get_statistics # rubocop:todo Naming/AccessorMethodName
+  def statistics
     I18n.locale = @medium.locale || I18n.default_locale
     medium_consumption = Consumption.where(medium_id: @medium.id)
     if @medium.video.present?

app/helpers/application_helper.rb

@@ -295,7 +295,7 @@ def first_course_independent?
                 &.first&.term_independent
   end
 
-  def get_announcements # rubocop:todo Naming/AccessorMethodName
+  def announcements
     megaphone_icon_str = '<i class="bi bi-megaphone p-2"></i>'
     separator_str = "<hr class=\"my-3 w-100\">#{megaphone_icon_str}"
     Announcement.active_on_main

app/mailers/exception_handler/exception_mailer.rb

@@ -10,8 +10,8 @@ class ExceptionMailer < ActionMailer::Base
     default template_path: "exception_handler/mailers"
     # => http://stackoverflow.com/a/18579046/1143732
 
-    def new_exception(e) # rubocop:todo Naming/MethodParameterName
-      @exception = e
+    def new_exception(err)
+      @exception = err
       mail to: ExceptionHandler.config.email
       Rails.logger.info "Exception Sent To → #{ExceptionHandler.config.email}"
     end

app/models/assignment.rb

@@ -107,7 +107,7 @@ def check_destructibility
     true
   end
 
-  def has_documents? # rubocop:todo Naming/PredicateName
+  def documents?
     return false unless medium
 
     medium.video || medium.manuscript || medium.geogebra ||

app/models/mampf_matrix.rb

@@ -18,7 +18,7 @@ def self.trivial_instance
         "matrix([0,0],[0,0]")
   end
 
-  def entry(i, j) # rubocop:todo Naming/MethodParameterName
+  def entry(i, j) # rubocop:disable Naming/MethodParameterName
     return "0" if i > @row_count || j > @column_count
 
     @coefficients[((i - 1) * @column_count) + (j - 1)]

app/models/medium.rb

@@ -1061,17 +1061,17 @@ def becomes_quizzable
     becomes(Remark)
   end
 
-  def containingWatchlists(user) # rubocop:todo Naming/MethodName
+  def containing_watchlists(user)
     Watchlist.where(id: WatchlistEntry.where(medium: self).pluck(:watchlist_id),
                     user: user)
   end
 
-  def containingWatchlistsNames(user) # rubocop:todo Naming/MethodName
-    watchlists = containingWatchlists(user)
+  def containing_watchlists_names(user)
+    watchlists = containing_watchlists(user)
     if watchlists.empty?
       ""
     else
-      containingWatchlists(user).pluck(:name)
+      watchlists.pluck(:name)
     end
   end
 

app/models/user.rb

@@ -650,10 +650,6 @@ def tutorials(lecture)
     given_tutorials.where(lecture: lecture)
   end
 
-  def has_tutorials?(lecture) # rubocop:todo Naming/PredicateName
-    !given_tutorials.where(lecture: lecture).empty?
-  end
-
   def proper_submissions_count
     submissions.proper.size
   end

app/models/watchlist.rb

@@ -7,9 +7,7 @@ class Watchlist < ApplicationRecord
   validates :name, presence: true, uniqueness: { scope: :user_id }
   # rubocop:enable Rails/UniqueValidationWithoutIndex
 
-  # rubocop:todo Naming/VariableName
-  def owned_by?(otherUser) # rubocop:todo Naming/MethodParameterName, Naming/VariableName
-    # rubocop:enable Naming/VariableName
-    user == otherUser # rubocop:todo Naming/VariableName
+  def owned_by?(other_user)
+    user == other_user
   end
 end

app/views/layouts/devise.html.erb

@@ -16,7 +16,7 @@
       <%# Announcements %>
         <% if Announcement.active_on_main.exists? %>
           <div id="announcement-box" class="landing-box">
-            <%= get_announcements().html_safe %>
+            <%= announcements().html_safe %>
           </div>
         <% end %>
 

app/views/media/_medium.html.erb

@@ -62,16 +62,16 @@
                title="<%= t('medium.waiting_for_tag') %>">
             </i>
           <% end %>
-          <% if !medium.containingWatchlists(current_user).empty? %>
+          <% if !medium.containing_watchlists(current_user).empty? %>
             <%= link_to '',
-                        watchlist_path(medium.containingWatchlists(current_user).first),
+                        watchlist_path(medium.containing_watchlists(current_user).first),
                         class: 'fas fa-bookmark text-light me-2',
                         style: 'text-decoration: none;',
                         data: { toggle: 'tooltip',
                                 placement: 'bottom' },
                         title: t('watchlist_entry.list',
-                                count: medium.containingWatchlists(current_user).size,
-                                watchlists: medium.containingWatchlistsNames(current_user).join(", ")) %>
+                                count: medium.containing_watchlists(current_user).size,
+                                watchlists: medium.containing_watchlists_names(current_user).join(", ")) %>
           <% end %>
           <%= link_to '',
                       add_medium_to_watchlist_path(medium),

app/views/submissions/_card.html.erb

@@ -27,7 +27,7 @@
 		</div>
 	</div>
 	<% if assignment&.medium&.visible_for_user?(current_user) &&
-  	      (assignment.medium.tags.present? || assignment.has_documents?) %>
+  	      (assignment.medium.tags.present? || assignment.documents?) %>
   	<ul class="list-group list-group-flush">
     	<li class="list-group-item submissionSubHeader">
     		<div class="row">
@@ -44,7 +44,7 @@
       			<% end %>
       		</div>
       		<div class="col-12">
-      			<% if assignment.has_documents? %>
+      			<% if assignment.documents? %>
         			<div class="flexdiv mt-2">
           			<%= render partial: 'media/medium/buttons',
             	  		       locals: { medium: assignment.medium,

config/routes.rb

@@ -340,9 +340,9 @@
        to: "media#register_download",
        as: "register_download"
 
-  get "media/:id/get_statistics",
-      to: "media#get_statistics",
-      as: "get_statistics"
+  get "media/:id/statistics",
+      to: "media#statistics",
+      as: "statistics"
 
   get "media/:id/show_comments",
       to: "media#show_comments",

spec/support/request_parse_helper.rb

@@ -1,24 +1,23 @@
 module RequestParsingHelper
   # Parse the request body as HTML and return the number of hits
   def parse_media_search(response)
-    # rubocop:todo Naming/VariableName
-    searchResults = response.body.match(/(?<=searchResults.innerHTML = ').*(?=';)/)[0].gsub('\n',
-                                                                                            "")
-    # rubocop:enable Naming/VariableName
-    # strip whitespaces in searchResults
-    searchResults = searchResults.gsub(/\s+/, " ") # rubocop:todo Naming/VariableName
-    # fix " in searchResults
-    searchResults = searchResults.gsub('\\\"', '"') # rubocop:todo Naming/VariableName
-    # fix \/ in searchResults
-    searchResults = searchResults.gsub('\\/', "/") # rubocop:todo Naming/VariableName
+    search_results = response.body
+                             .match(/(?<=search_results.innerHTML = ').*(?=';)/)[0]
+                             .gsub('\n', "")
+    # strip whitespaces in search_results
+    search_results = search_results.gsub(/\s+/, " ")
+    # fix " in search_results
+    search_results = search_results.gsub('\\\"', '"')
+    # fix \/ in search_results
+    search_results = search_results.gsub('\\/', "/")
 
-    # parse searchResults as html
-    searchResults = Nokogiri::HTML(searchResults) # rubocop:todo Naming/VariableName
+    # parse search_results as html
+    search_results = Nokogiri::HTML(search_results)
 
     # get text within first "col-12 col-lg-2" div
-    treffer = searchResults.css("div.col-12.col-lg-2").first.text # rubocop:todo Naming/VariableName
-    # get number in treffer
-    treffer.match(/\d+/)[0].to_i
+    matches = search_results.css("div.col-12.col-lg-2").first.text
+    # get number in matches
+    matches.match(/\d+/)[0].to_i
   end
 end