Skip to content
Linting

Add annotation tool & migrate to JS in Thyme Player #2506

Sign in to view logs

Add annotation tool & migrate to JS in Thyme Player

Add annotation tool & migrate to JS in Thyme Player #2506

Triggered via pull request January 19, 2024 12:42
@SplinesSplines
synchronize #533
annotation-tool
Status Failure
Total duration 2m 2s
Artifacts –

linter.yml

on: pull_request
RuboCop (Ruby)
1m 53s
RuboCop (Ruby)
ESLint (JS)
23s
ESLint (JS)
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
ESLint (JS): app/assets/javascripts/thyme/chapter_manager.js#L114
Expected a conditional expression and instead saw an assignment
ESLint (JS)
Process completed with exit code 1.
RuboCop (Ruby): app/controllers/media_controller.rb#L67
Style/ClassEqualityComparison: Use `instance_of?(::Lesson)` instead of comparing classes.
RuboCop (Ruby)
Process completed with exit code 1.
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L105
'annotations' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L120
'annotations' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L165
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L166
'close' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L184
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L202
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/chapter_manager.js#L75
'currentChapter' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/components/seek_bar.js#L21
'time' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/components/seek_bar.js#L72
'seconds' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/metadata_manager.js#L202
'time' is assigned a value but never used