Skip to content
Linting

Add annotation tool & migrate to JS in Thyme Player #2436

Sign in to view logs

Add annotation tool & migrate to JS in Thyme Player

Add annotation tool & migrate to JS in Thyme Player #2436

Triggered via pull request January 3, 2024 18:26
@SplinesSplines
synchronize #533
annotation-tool
Status Failure
Total duration 2m 11s
Artifacts –

linter.yml

on: pull_request
RuboCop (Ruby)
2m 1s
RuboCop (Ruby)
ESLint (JS)
22s
ESLint (JS)
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 11 warnings
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_manager.js#L61
Move function declaration to function body root
ESLint (JS): app/assets/javascripts/thyme/chapter_manager.js#L114
Expected a conditional expression and instead saw an assignment
ESLint (JS)
Process completed with exit code 1.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L5
Layout/IndentationStyle: Tab detected in indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L5
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L6
Layout/IndentationStyle: Tab detected in indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L7
Layout/IndentationStyle: Tab detected in indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L8
Layout/IndentationStyle: Tab detected in indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L8
Layout/TrailingWhitespace: Trailing whitespace detected.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L9
Layout/IndentationStyle: Tab detected in indentation.
RuboCop (Ruby): app/abilities/annotation_ability.rb#L11
Layout/TrailingWhitespace: Trailing whitespace detected.
RuboCop (Ruby): app/controllers/annotations_controller.rb#L2
Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.
RuboCop (Ruby): app/controllers/annotations_controller.rb#L59
Rails/ActionOrder: Action `show` should appear before `update`.
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L105
'annotations' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L120
'annotations' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L165
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L166
'close' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L184
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/annotations/annotation_area.js#L202
'annotation' is defined but never used. Allowed unused args must match /^_/u
ESLint (JS): app/assets/javascripts/thyme/chapter_manager.js#L75
'currentChapter' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/components/seek_bar.js#L21
'time' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/components/seek_bar.js#L72
'seconds' is assigned a value but never used
ESLint (JS): app/assets/javascripts/thyme/metadata_manager.js#L202
'time' is assigned a value but never used
RuboCop (Ruby): app/controllers/annotations_controller.rb#L146
Performance/InefficientHashSearch: Use `#value?` instead of `#values.include?`.