RedisCluster -> Mutable/Immutable #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! /cc @kardapoltsev @herzrasen this might be interesing for you as well |
kardapoltsev
reviewed
Jan 7, 2019
| redisServerConnections.keys.toSeq | ||
| } | ||
|
|
||
| def addServer(server: RedisServer) { |
There was a problem hiding this comment.
Procedure syntax is deprecated
kardapoltsev
reviewed
Jan 7, 2019
|
|
||
| protected val timeoutMillis: Option[Long] = timeout.map(_.toMillis) | ||
|
|
||
| if(timeout.isDefined) { |
kardapoltsev
reviewed
Jan 7, 2019
| @@ -1 +1 @@ | |||
| version := "1.8.4" | |||
| version := "2.0.0" | |||
There was a problem hiding this comment.
I think it shouldn't be a part of PR
|
first of all sorry, due to several time limitations I neglected this repository far too much. I'm not sure when exactly, but I hope that I can find some time to do a review here at one of the next weekends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This change addresses such issues as etaty#177 .
Essentially it is for supporting Redis clusters (in "cluster mode").
The previous versions of
rediscalasupport cluster mode, but theRedisClusterclass only accepts an immutable list of servers, and as such the list of nodes cannot change, however this does not allow the user to utilize Redis cluster features such as scaling out shards, adding or removing replication nodes, etc.This changes
RedisClusterto an abstract class. From there, I addedImmutableRedisClusterwhich is an implementation ofRedisClusterthat maintains the same functionality as in previous versions, andMutableRedisCluster, which is an abstract class that will refresh the list of nodes everynseconds, where the method of refreshing the list of nodes depends on the implementation.I have also added an implementation of
MutableRedisCluster,ClusterCommandRedisCluster, which uses theCLUSTER NODEScommand to refresh the list of nodes. This class accepts aconfigUrlas input which is based on the AWS Elasticache flavor of Redis clusters, but more generically theconfigUrlis aCNAMErecord from which the initial nodes can be discovered.This is a breaking change! Suggestions on how to make this a non-breaking change are welcomed (other suggestions are welcomed, too).