Ionospheric subtraction #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: Write thorough tests that intended visibilities make their way to the peel functions. Currently, averaging to 1.28 MHz isn't happening WIP: Add UVW cutoffs WIP: Fix error handling in src/cli/error.rs This is a squashed commit of months of work by CHJ and Dev. Big props to Dev for their help.
added a test that previously failed because of a byte padding issue.
In my testing it hasn't produced anything remotely like a gain.
joiner previously instantiated a new iterator on its receiver in a loop this consumed the stream if reading was faster than joining
- fix multiple bugs to do with frequency averaging - implement and test gain update - expose peel parameters: num_loops, short_baseline_sigma, convergence for more consistency in tests - remove low res modeller - clearer logging of frequency averaging parameters - unflag spw when it is read: peel can't handle channel gaps when averaging - zip eqs everywhere because why not - add a lot more tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 87.44% 88.30% +0.86%
==========================================
Files 110 115 +5
Lines 28614 32699 +4085
==========================================
+ Hits 25021 28875 +3854
- Misses 3593 3824 +231 ☔ View full report in Codecov by Sentry. |
|
currently missing:
|
- default output res is input res - clip output time factor if not enough timestamps. - freq averaging tests
refactor PeelWeightParams derive lambdas from chanblocks derive array pos, dut from obs_context derive unflagged_xyzs from tile_baseline_flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.