Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mise en avant newsletter #469

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Mise en avant newsletter #469

wants to merge 7 commits into from

Conversation

pyDez
Copy link
Collaborator

@pyDez pyDez commented Nov 8, 2024

@pyDez pyDez closed this Nov 8, 2024
@pyDez pyDez reopened this Nov 8, 2024
@pyDez pyDez closed this Nov 8, 2024
@pyDez pyDez reopened this Nov 8, 2024
@pyDez pyDez requested a review from thibault November 8, 2024 08:44

def form_valid(self, form):
"""Send the form data to Brevo API."""
if not settings.BREVO.get("API_KEY"):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je m'interroge sur cette gestion d'erreur. S'il y a un problème de settings manquant, c'est l'équipe EnvErgo qui devrait recevoir une erreur, pas l'utilisateur. Ici, le message affiché laisse penser à l'utilisateur qu'il y a une erreur de son côté ce qui n'est pas le cas. Au moins ajouter un log d'erreur avec logger.error ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants