Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dwidenoise: Fixed output rank #3046

Closed
Lestropie opened this issue Nov 25, 2024 · 0 comments
Closed

dwidenoise: Fixed output rank #3046

Lestropie opened this issue Nov 25, 2024 · 0 comments
Labels

Comments

@Lestropie
Copy link
Member

The modularised implementation in #3029 makes it very easy to introduce alternative mechanisms for PCA threshold selection. One possibility suggested here by @jelleveraart is to simply fix the output rank, irrespective of the eigenvalue spectrum. This should be reasonably trivial code-wise.

I'm not sure whether this should be made mutually exclusive with respect to optimal shrinkage, or whether they should just be left as independent mechanisms and users can configure however they wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant