Fix AppThemeItem

- Optimize `ModuleItem`
MRepoApp · Jun 21, 2024 · 4a6c80a · 4a6c80a
1 parent 4b12236
commit 4a6c80a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/modules/ModuleItem.kt b/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/modules/ModuleItem.kt
@@ -59,7 +59,7 @@ internal fun ModuleItem(
     val userPreferences = LocalUserPreferences.current
     val menu = userPreferences.modulesMenu
 
-    val versionDisplay by remember {
+    val versionDisplay by remember(module) {
         derivedStateOf { module.versionDisplay }
     }
 

diff --git a/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/modules/ModulesList.kt b/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/modules/ModulesList.kt
@@ -90,7 +90,7 @@ fun ModuleItem(
     val ops by remember(module.state) {
         derivedStateOf { getModuleOps(module) }
     }
-    val item by remember {
+    val item by remember(module) {
         derivedStateOf { getVersionItem(module) }
     }
 

diff --git a/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/settings/app/items/DarkModeItem.kt b/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/settings/app/items/DarkModeItem.kt
@@ -91,7 +91,9 @@ private fun DarkModeItem(
     darkMode: DarkMode,
     onChange: (DarkMode) -> Unit
 ) {
-    val selected by remember { derivedStateOf { item.value == darkMode } }
+    val selected by remember(darkMode) {
+        derivedStateOf { item.value == darkMode }
+    }
 
     Box(
         modifier = Modifier

diff --git a/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/settings/app/items/ThemePaletteItem.kt b/app/src/main/kotlin/dev/sanmer/mrepo/ui/screens/settings/app/items/ThemePaletteItem.kt
@@ -65,9 +65,12 @@ private fun ThemeColorItem(
     isDarkMode: Boolean,
     onChange: (Int) -> Unit
 ) {
-    val selected by remember { derivedStateOf { id == themeColor } }
+    val selected by remember(themeColor) {
+        derivedStateOf { id == themeColor }
+    }
+
     val color = Colors.getColor(id)
-    val colorScheme by remember {
+    val colorScheme by remember(isDarkMode) {
         derivedStateOf {
             when {
                 isDarkMode -> color.darkColorScheme