Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace popup by confirm #308

Merged
merged 1 commit into from
Sep 11, 2019
Merged

replace popup by confirm #308

merged 1 commit into from
Sep 11, 2019

Conversation

xi
Copy link
Collaborator

@xi xi commented May 14, 2019 •
edited
Loading

We have a lot of popups that just ask for a yes/no answer. For that there is a builtin confirm dialog. This has several benefits:

  • The current popup solution is not actually that great from a UX perspective. For example, the popups don't close when the containing dropdown closes.
  • Some inline JS is removed which is great for security (see Eleminate all inline javascript #241). The workaround from Fix popover #305 can be removed.
  • Accessibility is better.
  • Complexity is lower.

Unfortunately bootstrap3 does not support forms/buttons inside dropdowns. So this has to wait for #181.

@octomike octomike added this to the 2.5.0 milestone May 22, 2019
@xi xi mentioned this pull request Jul 16, 2019
Merged
@xi xi force-pushed the popup-confirm branch from da34155 to 4f66f2f Compare July 17, 2019 07:25
@xi xi changed the title WIP: replace popup by confirm replace popup by confirm Jul 17, 2019
@xi xi force-pushed the popup-confirm branch from 4f66f2f to 1765cee Compare July 22, 2019 07:19
@octomike octomike modified the milestones: 2.6.0 - bootstrap 4, 2.4.0 - Django 2.2 and Bootstrap 4 Sep 11, 2019
@octomike octomike merged commit 419b8a1 into develop Sep 11, 2019
@octomike octomike deleted the popup-confirm branch February 13, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0 - Django 2.2 and Bootstrap 4
Development

Successfully merging this pull request may close these issues.
2 participants
@xi @octomike