Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace filter/sort/pagination #269

Merged
merged 5 commits into from
Oct 29, 2018
Merged

Conversation

xi
Copy link
Collaborator

@xi xi commented Oct 10, 2018

This replaces a lot of inline javascript by a single generic implementation. This new implementation is more generic, but also more complex.

I am not entirely happy with this solution. I believe this feature should not require javascript at all. Still, this is a step towards #241

@octomike octomike merged commit 5f52c1c into develop Oct 29, 2018
@xi xi mentioned this pull request Jul 17, 2019
@octomike octomike deleted the replace-filter-sort-pagination branch February 12, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants