Refactor: reduce amount of inline javascript #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xi
changed the title
|
related to #241 |
octomike
reviewed
Sep 7, 2018
devices/templatetags/devicetags.py
Outdated
|
|
||
|
|
||
| @register.inclusion_tag('deletebutton.html') | ||
| def deletebutton(viewname, *args): |
There was a problem hiding this comment.
ah yes, I like that :)
But the template changes make the button look very differently.
Also, should that html go to snippets/ ?
There was a problem hiding this comment.
I thought that all instances were the same, but obviously I missed something. Will look into it. Do you have some insights of which different cases exist?
octomike
reviewed
Sep 7, 2018
| @@ -486,6 +504,7 @@ <h4>{% trans "10 last sent mails" %}</h4> | |||
| <td>{{ mail.subject }}</td> | |||
| <td><a href="{% url 'userprofile' mail.sent_by.pk %}">{{ mail.sent_by }}</a></td> | |||
| <td><span title="{{ mail.sent_at|date:'c' }}" | |||
| data-timeago | |||
There was a problem hiding this comment.
Do you know why that was previously wrapped inside a document.ready() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.