Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] seperate LLM models #229

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

leeeizhang
Copy link
Collaborator

To further support additional models, it is suggested to separate LLMs into a model package to reduce code complexity.

Before submitting this PR, please make sure you have:

  • confirmed all checks still pass OR confirm CI build passes.
  • verified that any code or assets from external sources are properly credited in comments and/or in
    the credit file.

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 8, 2024
@leeeizhang leeeizhang changed the title [WIP] seperate LLM models [MRG] seperate LLM models Oct 8, 2024
@dosubot dosubot bot added the enhancement New feature or request label Oct 8, 2024
Copy link
Member

@huangyz0918 huangyz0918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see this!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2024
@huangyz0918 huangyz0918 merged commit 985c24e into MLSysOps:main Oct 8, 2024
4 checks passed
@leeeizhang leeeizhang deleted the lei/seperate-models branch October 9, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants