Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load fix #454

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Load fix #454

merged 3 commits into from
Mar 26, 2024

Conversation

blaiszik
Copy link
Contributor

Fixes loading of Foundry datasets submitted using the new MDF Connect server less flow

Copy link

what-the-diff bot commented Mar 26, 2024

PR Summary

  • Improved Search Functionality in Foundry
    The foundry.py file was updated to enhance its search capabilities. This includes amending the match_field method to handle required terms and augmenting the search query with the capacity to match the organization.

  • Enhanced Connection Testing in Foundry
    There is a newly introduced conditional block in foundry.py focused on the test mode for client-connection, increasing stability and reliability of the application.

  • Handling API Versioning in Foundry
    To stay up-to-date and compatible with different versions of the API, added conditionals adjust folder addressing and API handling as needed.

  • Efficient Directory Creation in https_download.py
    Added 'exist_ok=True' parameter to the os.makedirs method which allows for swifter and more effective folder creation by ignoring warnings if folders already exist.

  • Dependencies Update
    Both the requirements.txt and setup.py files were updated to include the openpyxl package. This library aids in reading/writing Excel 2010 xlsx/xlsm/xltx/xltm files, which can be valuable when dealing with data in these formats.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 72.17%. Comparing base (0ccb39b) to head (f4ce5e5).
Report is 47 commits behind head on main.

❗ Current head f4ce5e5 differs from pull request most recent head 8e12fb1. Consider uploading reports for the commit 8e12fb1 to get more accurate results

Files Patch % Lines
foundry/foundry.py 63.63% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   72.08%   72.17%   +0.08%     
==========================================
  Files           9        9              
  Lines         541      557      +16     
==========================================
+ Hits          390      402      +12     
- Misses        151      155       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blaiszik blaiszik merged commit 2ec46bc into main Mar 26, 2024
4 of 6 checks passed
@blaiszik blaiszik deleted the load-fix branch June 12, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants