-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoiding issues with analyst data objects #1307
Open
chrisr3d
wants to merge
8
commits into
MISP:main
Choose a base branch
from
chrisr3d:analyst_data_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1dce13d - Browse repository at this point
Copy the full SHA 1dce13dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e288a4 - Browse repository at this point
Copy the full SHA 8e288a4View commit details
Commits on Nov 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2f76ae2 - Browse repository at this point
Copy the full SHA 2f76ae2View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6a961a - Browse repository at this point
Copy the full SHA e6a961aView commit details
Commits on Nov 19, 2024
-
chg: [AnalystData] Flattening analyst data based on the recent change…
…s on MISP standard format - Adding a note or an opinion will always add the new analyst data object to the list of notes or opinions at the parent data layer level - `from_dict` on a JSON blob is also able to parse properly analyst data and generate flat lists regardless of whether the given data described in the new flat or previously nested format
Configuration menu - View commit details
-
Copy full SHA for df39554 - Browse repository at this point
Copy the full SHA df39554View commit details
Commits on Nov 20, 2024
-
fix: [MISPAnalystData] Better handling of the different use cases
- Additional checks for parent to support both the standalone and attached analyst data objects - Standalone Analyst data objects with nested notes or opinions are defined with the nesting as they have no parent. When they are added to a parent data layer, the nested objects are then flattened
Configuration menu - View commit details
-
Copy full SHA for ea6ff20 - Browse repository at this point
Copy the full SHA ea6ff20View commit details -
fix: [MISPAnalystData] Reverted the declaration of Analyst data objec…
…ts lists back to the mixin parent class
Configuration menu - View commit details
-
Copy full SHA for 6ca367d - Browse repository at this point
Copy the full SHA 6ca367dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 90b8f58 - Browse repository at this point
Copy the full SHA 90b8f58View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.