testing: assert_allclose with allowed failures #563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A helper function to check if two arrays are close, but allows a number of failures. This could help with #501 where most of the array is close but some points are not & expect this could become more important? Uses the numpy machinery, thus does not work with xarray. However, there is no
isclose
function forDataArray
andDataset
andxr.testing.assert_allclose
is a mess.See also
np.testing.assert_allclose??