-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MESMER-X : Add calibration of local variability to calibration test #550
MESMER-X : Add calibration of local variability to calibration test #550
Conversation
@yquilcaille could you tell me if you also adjust the localized covariance with the AR parameters for MESMER-X? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
+ Coverage 62.74% 63.36% +0.61%
==========================================
Files 50 50
Lines 3554 3554
==========================================
+ Hits 2230 2252 +22
+ Misses 1324 1302 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
So the answer to that is yes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks
That seems to be a mamba problem... You can try to close and reopen to see if it's intermittent or pin to v2.0.3 (which worked yesterday) mesmer/.github/workflows/ci-workflow.yml Line 55 in bc50d05
|
Ok - v2.0.3 has been marked as broken (mamba-org/mamba#3576) so it should work again (but I don't know how long that will take) |
If you restart your build, it should work! |
Thanks! |
Can I have an approval @mathause 🥺 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice - thanks.
Co-authored-by: Mathias Hauser <[email protected]>
To be able to test emulations, we need to also calibrate the local AR params and the covariance matrix for MESMER-X
CHANGELOG.rst