Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESMER-X : Add calibration of local variability to calibration test #550

Merged

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented Nov 4, 2024

To be able to test emulations, we need to also calibrate the local AR params and the covariance matrix for MESMER-X

  • Tests added
  • Fully documented, including CHANGELOG.rst

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

@yquilcaille could you tell me if you also adjust the localized covariance with the AR parameters for MESMER-X?

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.36%. Comparing base (c66cb2d) to head (25a1b60).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   62.74%   63.36%   +0.61%     
==========================================
  Files          50       50              
  Lines        3554     3554              
==========================================
+ Hits         2230     2252      +22     
+ Misses       1324     1302      -22     
Flag Coverage Δ
unittests 63.36% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

if you also adjust the localized covariance with the AR parameters for MESMER-X?

So the answer to that is yes :)

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi requested review from mathause and removed request for yquilcaille November 5, 2024 16:29
Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks

tests/integration/test_calibrate_mesmer_x.py Outdated Show resolved Hide resolved
tests/integration/test_calibrate_mesmer_x.py Outdated Show resolved Hide resolved
tests/integration/test_calibrate_mesmer_x.py Outdated Show resolved Hide resolved
@mathause
Copy link
Member

mathause commented Nov 7, 2024

That seems to be a mamba problem... You can try to close and reopen to see if it's intermittent or pin to v2.0.3 (which worked yesterday)

uses: mamba-org/setup-micromamba@v2

@mathause
Copy link
Member

mathause commented Nov 7, 2024

Ok - v2.0.3 has been marked as broken (mamba-org/mamba#3576) so it should work again (but I don't know how long that will take)

@SylvainCorlay
Copy link

Ok - v2.0.3 has been marked as broken (mamba-org/mamba#3576) so it should work again (but I don't know how long that will take)

If you restart your build, it should work!

@mathause
Copy link
Member

mathause commented Nov 7, 2024

Ok - v2.0.3 has been marked as broken (mamba-org/mamba#3576) so it should work again (but I don't know how long that will take)

If you restart your build, it should work!

Thanks!

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Can I have an approval @mathause 🥺

Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks.

tests/integration/test_calibrate_mesmer_x.py Show resolved Hide resolved
tests/integration/test_calibrate_mesmer_x.py Outdated Show resolved Hide resolved
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 92ac938 into MESMER-group:main Nov 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants